Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vd): fix fake pvc resizing #159

Merged
merged 2 commits into from
Jun 27, 2024
Merged

fix(vd): fix fake pvc resizing #159

merged 2 commits into from
Jun 27, 2024

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented Jun 26, 2024 •
edited
Loading

Description

  • Took into account the case when the size of the PVC in the spec and status can differ (for example, when the spec is 1G, but the status shows 976563Ki).
  • Added tests for ResizingHandler.
  • Fixed watch for pvc (not a controller reference)
  • Added a missed Resizing phase

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@Isteb4k Isteb4k force-pushed the fix/vd/fake-resizing branch from 0264f46 to c25f0b9 Compare June 26, 2024 10:08
@Isteb4k Isteb4k marked this pull request as draft June 26, 2024 10:41
@Isteb4k Isteb4k force-pushed the fix/vd/fake-resizing branch 5 times, most recently from d8127e9 to cc1a057 Compare June 26, 2024 16:52
@Isteb4k Isteb4k marked this pull request as ready for review June 26, 2024 17:02
@Isteb4k Isteb4k requested a review from diafour June 26, 2024 18:04
LopatinDmitr
LopatinDmitr previously approved these changes Jun 26, 2024
View reviewed changes
@Isteb4k Isteb4k force-pushed the fix/vd/fake-resizing branch from cc1a057 to 8aa47f5 Compare June 27, 2024 08:28
@Isteb4k Isteb4k force-pushed the fix/vd/fake-resizing branch from 8aa47f5 to 60977a6 Compare June 27, 2024 08:30
@Isteb4k Isteb4k force-pushed the fix/vd/fake-resizing branch from 60977a6 to 32193d6 Compare June 27, 2024 09:02
@Isteb4k Isteb4k merged commit 6b4d431 into main Jun 27, 2024
1 check passed
@Isteb4k Isteb4k deleted the fix/vd/fake-resizing branch June 27, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diafour diafour diafour approved these changes

@LopatinDmitr LopatinDmitr LopatinDmitr left review comments

Assignees

@Isteb4k Isteb4k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isteb4k @diafour @LopatinDmitr